Adjust plugin filename scan for better performance (#3514)

* Adjust plugin filename scan for better performance * reorder * lint * Update custom_components/hacs/repositories/plugin.py Co-authored-by: J. Nick Koston <[email protected]> * Update custom_components/hacs/repositories/plugin.py Co-authored-by: J. Nick Koston <[email protected]> --------- Co-authored-by: J. Nick Koston <[email protected]>
hacs · May 23, 2024 · 69e197c · 69e197c
1 parent 9ad1e76
commit 69e197c
Showing 1 changed file with 14 additions and 12 deletions.
diff --git a/custom_components/hacs/repositories/plugin.py b/custom_components/hacs/repositories/plugin.py
@@ -99,9 +99,9 @@ async def get_package_content(self):
 
     def update_filenames(self) -> None:
         """Get the filename to target."""
-        # Handler for plug requirement 3
-        if self.repository_manifest.filename:
-            valid_filenames = (self.repository_manifest.filename,)
+        content_in_root = self.repository_manifest.content_in_root
+        if specific_filename := self.repository_manifest.filename:
+            valid_filenames = (specific_filename,)
         else:
             valid_filenames = (
                 f"{self.data.name.replace('lovelace-', '')}.js",
@@ -110,7 +110,7 @@ def update_filenames(self) -> None:
                 f"{self.data.name}-bundle.js",
             )
 
-        if not self.repository_manifest.content_in_root:
+        if not content_in_root:
             if self.releases.objects:
                 release = self.releases.objects[0]
                 if release.assets:
@@ -124,11 +124,13 @@ def update_filenames(self) -> None:
                         self.content.path.remote = "release"
                         return
 
-        for location in ("",) if self.repository_manifest.content_in_root else ("dist", ""):
-            for filename in valid_filenames:
-                if f"{location+'/' if location else ''}{filename}" in [
-                    x.full_path for x in self.tree
-                ]:
-                    self.data.file_name = filename.split("/")[-1]
-                    self.content.path.remote = location
-                    break
+        all_paths = {x.full_path for x in self.tree}
+        for filename in valid_filenames:
+            if filename in all_paths:
+                self.data.file_name = filename
+                self.content.path.remote = ""
+                return
+            if not content_in_root and f"dist/{filename}" in all_paths:
+                self.data.file_name = filename.split("/")[-1]
+                self.content.path.remote = "dist"
+                return