Use freezegun in tests and add last_fetched to snapshots (#3599)

* Use freezegun in tests and add last_fetched to snapshots * lint * Remove incorrect workaround * Also patch the monotonic timer * Set non UTC system timezone in tests * Change to a fork of szenius/set-timezone * Accept review comment * Revert CI timezone to UTC --------- Co-authored-by: Erik <[email protected]>
hacs · Apr 11, 2024 · 13c1c4b · 13c1c4b
1 parent 51addbb
commit 13c1c4b
Show file tree

Hide file tree

Showing 35 changed files with 93 additions and 3 deletions.
diff --git a/requirements_test.txt b/requirements_test.txt
@@ -1,6 +1,7 @@
 -r requirements_base.txt
 asynctest==0.13.0
 fnv-hash-fast==0.5.0
+freezegun==1.4.0
 home-assistant-frontend
 homeassistant
 janus==1.0.0

diff --git a/tests/common.py b/tests/common.py
@@ -174,7 +174,7 @@ def _sort_list(entry):
         value = data[key]
         if key in to_remove:
             continue
-        elif isinstance(value, (str, bool, int, NoneType)):
+        elif isinstance(value, (str, bool, int, float, NoneType)):
             returndata[key] = value
         elif isinstance(value, dict):
             returndata[key] = recursive_remove_key(

diff --git a/tests/conftest.py b/tests/conftest.py
@@ -1,5 +1,6 @@
 """Set up some common test helper things."""
 # pytest: disable=protected-access
+from . import patch_time  # noqa: F401, isort:skip
 import asyncio
 from collections import OrderedDict
 from dataclasses import asdict
@@ -12,6 +13,7 @@
 from unittest.mock import MagicMock, patch
 
 from awesomeversion import AwesomeVersion
+import freezegun
 from homeassistant import loader
 from homeassistant.auth.models import Credentials
 from homeassistant.auth.providers.homeassistant import HassAuthProvider
@@ -76,6 +78,12 @@
 asyncio.sleep = lambda _: _sleep(0)
 
 
+@pytest.fixture(autouse=True)
+def time_freezer():
+    with freezegun.freeze_time("2019-02-26T15:02:39Z"):
+        yield
+
+
 @pytest.fixture(autouse=True)
 def set_request_context(request: pytest.FixtureRequest):
     """Set request context for every test."""
@@ -106,7 +114,7 @@ def event_loop():
 
 
 @pytest.fixture
-def hass(event_loop, tmpdir, check_report_issue: None):
+def hass(time_freezer, event_loop, tmpdir, check_report_issue: None):
     """Fixture to provide a test instance of Home Assistant."""
 
     def exc_handle(loop, context):
@@ -265,7 +273,7 @@ async def assert_hacs_data(
                         ),
                         **(additional or {}),
                     },
-                    ("categories", "config_entry_id", "device_id", "labels", "last_fetched"),
+                    ("categories", "config_entry_id", "device_id", "labels"),
                 )
             ),
             filename,

diff --git a/tests/patch_time.py b/tests/patch_time.py
@@ -0,0 +1,26 @@
+"""Patch time related functions.
+
+Copied from Home Assistant Core.
+"""
+from __future__ import annotations
+
+import datetime
+import time
+
+from homeassistant import runner, util
+from homeassistant.util import dt as dt_util
+
+
+def _utcnow() -> datetime.datetime:
+    """Make utcnow patchable by freezegun."""
+    return datetime.datetime.now(tz=datetime.UTC)
+
+
+def _monotonic() -> float:
+    """Make monotonic patchable by freezegun."""
+    return time.monotonic()
+
+
+dt_util.utcnow = _utcnow  # type: ignore[assignment]
+util.utcnow = _utcnow  # type: ignore[assignment]
+runner.monotonic = _monotonic  # type: ignore[assignment]
diff --git a/tests/snapshots/hacs-test-org/appdaemon-basic/test_download_repository.json b/tests/snapshots/hacs-test-org/appdaemon-basic/test_download_repository.json
@@ -10,6 +10,7 @@
                 "installed": true,
                 "installed_commit": "7fd1a60",
                 "last_commit": "7fd1a60",
+                "last_fetched": 1551193359.0,
                 "last_updated": "2011-01-26T19:06:43Z",
                 "last_version": "1.0.0",
                 "published_tags": [
@@ -42,6 +43,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "open_issues": 2,

diff --git a/tests/snapshots/hacs-test-org/appdaemon-basic/test_remove_repository_post.json b/tests/snapshots/hacs-test-org/appdaemon-basic/test_remove_repository_post.json
@@ -19,6 +19,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "open_issues": 2,

diff --git a/tests/snapshots/hacs-test-org/appdaemon-basic/test_remove_repository_pre.json b/tests/snapshots/hacs-test-org/appdaemon-basic/test_remove_repository_pre.json
@@ -6,6 +6,7 @@
                 "full_name": "hacs-test-org/appdaemon-basic",
                 "id": "1296265",
                 "installed": true,
+                "last_fetched": 0.0,
                 "repository_manifest": {}
             }
         },
@@ -22,6 +23,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "open_issues": 2,

diff --git a/tests/snapshots/hacs-test-org/appdaemon-basic/test_update_repository_entity.json b/tests/snapshots/hacs-test-org/appdaemon-basic/test_update_repository_entity.json
@@ -10,6 +10,7 @@
                 "installed": true,
                 "installed_commit": "7fd1a60",
                 "last_commit": "7fd1a60",
+                "last_fetched": 1551193359.0,
                 "last_updated": "2011-01-26T19:06:43Z",
                 "last_version": "1.0.0",
                 "published_tags": [
@@ -41,6 +42,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "releases": true,

diff --git a/tests/snapshots/hacs-test-org/appdaemon-basic/test_update_repository_websocket.json b/tests/snapshots/hacs-test-org/appdaemon-basic/test_update_repository_websocket.json
@@ -10,6 +10,7 @@
                 "installed": true,
                 "installed_commit": "7fd1a60",
                 "last_commit": "7fd1a60",
+                "last_fetched": 1551193359.0,
                 "last_updated": "2011-01-26T19:06:43Z",
                 "last_version": "1.0.0",
                 "published_tags": [
@@ -43,6 +44,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "open_issues": 2,

diff --git a/tests/snapshots/hacs-test-org/integration-basic/test_download_repository.json b/tests/snapshots/hacs-test-org/integration-basic/test_download_repository.json
@@ -19,6 +19,7 @@
                 "installed": true,
                 "installed_commit": "7fd1a60",
                 "last_commit": "7fd1a60",
+                "last_fetched": 1551193359.0,
                 "last_updated": "2011-01-26T19:06:43Z",
                 "last_version": "1.0.0",
                 "manifest_name": "Proxy manifest",
@@ -46,6 +47,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "open_issues": 2,

diff --git a/tests/snapshots/hacs-test-org/integration-basic/test_remove_repository_post.json b/tests/snapshots/hacs-test-org/integration-basic/test_remove_repository_post.json
@@ -19,6 +19,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "open_issues": 2,

diff --git a/tests/snapshots/hacs-test-org/integration-basic/test_remove_repository_pre.json b/tests/snapshots/hacs-test-org/integration-basic/test_remove_repository_pre.json
@@ -13,6 +13,7 @@
                 "full_name": "hacs-test-org/integration-basic",
                 "id": "1296269",
                 "installed": true,
+                "last_fetched": 0.0,
                 "repository_manifest": {}
             },
             "172733314": {
@@ -23,6 +24,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "open_issues": 2,

diff --git a/tests/snapshots/hacs-test-org/integration-basic/test_update_repository_entity.json b/tests/snapshots/hacs-test-org/integration-basic/test_update_repository_entity.json
@@ -19,6 +19,7 @@
                 "installed": true,
                 "installed_commit": "7fd1a60",
                 "last_commit": "7fd1a60",
+                "last_fetched": 1551193359.0,
                 "last_updated": "2011-01-26T19:06:43Z",
                 "last_version": "1.0.0",
                 "manifest_name": "Proxy manifest",
@@ -45,6 +46,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "releases": true,

diff --git a/tests/snapshots/hacs-test-org/integration-basic/test_update_repository_websocket.json b/tests/snapshots/hacs-test-org/integration-basic/test_update_repository_websocket.json
@@ -18,6 +18,7 @@
                 "installed": true,
                 "installed_commit": "7fd1a60",
                 "last_commit": "7fd1a60",
+                "last_fetched": 1551193359.0,
                 "last_updated": "2011-01-26T19:06:43Z",
                 "last_version": "1.0.0",
                 "manifest_name": "Proxy manifest",
@@ -46,6 +47,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "open_issues": 2,

diff --git a/tests/snapshots/hacs-test-org/plugin-basic/test_download_repository.json b/tests/snapshots/hacs-test-org/plugin-basic/test_download_repository.json
@@ -19,6 +19,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "open_issues": 2,
@@ -44,6 +45,7 @@
                 "installed": true,
                 "installed_commit": "7fd1a60",
                 "last_commit": "7fd1a60",
+                "last_fetched": 1551193359.0,
                 "last_updated": "2011-01-26T19:06:43Z",
                 "last_version": "1.0.0",
                 "published_tags": [

diff --git a/tests/snapshots/hacs-test-org/plugin-basic/test_remove_repository_post.json b/tests/snapshots/hacs-test-org/plugin-basic/test_remove_repository_post.json
@@ -19,6 +19,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "open_issues": 2,

diff --git a/tests/snapshots/hacs-test-org/plugin-basic/test_remove_repository_pre.json b/tests/snapshots/hacs-test-org/plugin-basic/test_remove_repository_pre.json
@@ -19,6 +19,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "open_issues": 2,
@@ -40,6 +41,7 @@
                 "full_name": "hacs-test-org/plugin-basic",
                 "id": "1296267",
                 "installed": true,
+                "last_fetched": 0.0,
                 "repository_manifest": {}
             }
         },

diff --git a/tests/snapshots/hacs-test-org/plugin-basic/test_update_repository_entity.json b/tests/snapshots/hacs-test-org/plugin-basic/test_update_repository_entity.json
@@ -18,6 +18,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "releases": true,
@@ -42,6 +43,7 @@
                 "installed": true,
                 "installed_commit": "7fd1a60",
                 "last_commit": "7fd1a60",
+                "last_fetched": 1551193359.0,
                 "last_updated": "2011-01-26T19:06:43Z",
                 "last_version": "1.0.0",
                 "published_tags": [

diff --git a/tests/snapshots/hacs-test-org/plugin-basic/test_update_repository_websocket.json b/tests/snapshots/hacs-test-org/plugin-basic/test_update_repository_websocket.json
@@ -19,6 +19,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "open_issues": 2,
@@ -44,6 +45,7 @@
                 "installed": true,
                 "installed_commit": "7fd1a60",
                 "last_commit": "7fd1a60",
+                "last_fetched": 1551193359.0,
                 "last_updated": "2011-01-26T19:06:43Z",
                 "last_version": "1.0.0",
                 "published_tags": [

diff --git a/tests/snapshots/hacs-test-org/python_script-basic/test_download_repository.json b/tests/snapshots/hacs-test-org/python_script-basic/test_download_repository.json
@@ -19,6 +19,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "open_issues": 2,
@@ -50,6 +51,7 @@
                 "installed": true,
                 "installed_commit": "7fd1a60",
                 "last_commit": "7fd1a60",
+                "last_fetched": 1551193359.0,
                 "last_updated": "2011-01-26T19:06:43Z",
                 "last_version": "1.0.0",
                 "published_tags": [

diff --git a/tests/snapshots/hacs-test-org/python_script-basic/test_remove_repository_post.json b/tests/snapshots/hacs-test-org/python_script-basic/test_remove_repository_post.json
@@ -19,6 +19,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "open_issues": 2,

diff --git a/tests/snapshots/hacs-test-org/python_script-basic/test_remove_repository_pre.json b/tests/snapshots/hacs-test-org/python_script-basic/test_remove_repository_pre.json
@@ -19,6 +19,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "open_issues": 2,
@@ -46,6 +47,7 @@
                 "full_name": "hacs-test-org/python_script-basic",
                 "id": "1296262",
                 "installed": true,
+                "last_fetched": 0.0,
                 "repository_manifest": {}
             }
         },

diff --git a/tests/snapshots/hacs-test-org/python_script-basic/test_update_repository_entity.json b/tests/snapshots/hacs-test-org/python_script-basic/test_update_repository_entity.json
@@ -18,6 +18,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "releases": true,
@@ -48,6 +49,7 @@
                 "installed": true,
                 "installed_commit": "7fd1a60",
                 "last_commit": "7fd1a60",
+                "last_fetched": 1551193359.0,
                 "last_updated": "2011-01-26T19:06:43Z",
                 "last_version": "1.0.0",
                 "published_tags": [

diff --git a/tests/snapshots/hacs-test-org/python_script-basic/test_update_repository_websocket.json b/tests/snapshots/hacs-test-org/python_script-basic/test_update_repository_websocket.json
@@ -19,6 +19,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "open_issues": 2,
@@ -50,6 +51,7 @@
                 "installed": true,
                 "installed_commit": "7fd1a60",
                 "last_commit": "7fd1a60",
+                "last_fetched": 1551193359.0,
                 "last_updated": "2011-01-26T19:06:43Z",
                 "last_version": "1.0.0",
                 "published_tags": [

diff --git a/tests/snapshots/hacs-test-org/template-basic/test_download_repository.json b/tests/snapshots/hacs-test-org/template-basic/test_download_repository.json
@@ -19,6 +19,7 @@
                 "full_name": "hacs/integration",
                 "id": "172733314",
                 "installed": true,
+                "last_fetched": 1551193359.0,
                 "last_updated": "2023-11-18T21:22:03Z",
                 "manifest_name": "HACS",
                 "open_issues": 2,
@@ -57,6 +58,7 @@
                 "installed": true,
                 "installed_commit": "7fd1a60",
                 "last_commit": "7fd1a60",
+                "last_fetched": 1551193359.0,
                 "last_updated": "2011-01-26T19:06:43Z",
                 "last_version": "1.0.0",
                 "published_tags": [