Make URLs end with a trailing slash + replace some hardcoded URLs with lookups #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reasons: * Many/most of the website's views use a trailing slash in their URLs, so this will make it consistent and (hopefully) establish an internal convention * To my knowledge, it's conventional for (Django) websites to use a trailing slash in URLs (except for URLs to files, of course) * Django redirects URLs *missing* a trailing slash to the same URL *with* a trailing slash by default, but not vice versa (see https://docs.djangoproject.com/en/stable/ref/settings/#append-slash) * This fixes a 404 bug introduced in 85c78ca - which removed the trailing slash from the "news:details" path
|
Fixed the merge conflict in a new branch, because I can not modify a branch outside of this repo, see #810. Good work! |
Nice, thanks 😊
Thought I'd let you know that, actually, you can, since I (and most people when creating a PR from a fork) left the "Allow edits and access to secrets by maintainers" checkbox checked when creating the PR, which allows maintainers to e.g. rebase and push to that specific branch 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made most of the project's URLs end with a trailing slash (0ba27aa).
Reasons:
APPEND_SLASHsetting)Also:
success_urls with lookups (8b20b52)hrefs with lookups (aa22ea0)Note that I've not taken the time to test the code after making these changes (other than running the tests, which don't seem to cover most of the URLs), but I have been thorough in checking the whole codebase for references to the old URLs. Nonetheless, I'd appreciate if one of the maintainers could help me catch any URLs I might have missed :)