Exchange: remove dependency on NumberFormat

h4kuna · Jan 12, 2023 · daec714 · daec714
1 parent cba295b
commit daec714
Show file tree

Hide file tree

Showing 8 changed files with 6 additions and 238 deletions.
diff --git a/README.md b/README.md
@@ -46,46 +46,12 @@ echo $exchange->change(100, 'usd', 'czk'); // USD -> CZK = 2000.0
 
 ### Change driver and date
 
-Download history exchange rates.
+Download history exchange rates. Make new instance of Exchange with history rate.
 
 ```php
 $exchange = $exchangeFactory->create(new \Datetime('2000-12-30'));
 ```
 
-### Format output
-
-Define output formats, for more information read this documentation [h4kuna/number-format](//github.com/h4kuna/number-format#numberformatstate).
-
-```php
-$formats = new Exchange\Currency\Formats(new \h4kuna\Number\NumberFormatFactory());
-
-$formats->addFormat('EUR', ['decimalPoint' => '.', 'unit' => '€']);
-```
-
-Create [Filters](src/Filters.php) for format API.
-
-```php
-$filters = new Exchange\Filters($exchange, $formats, new h4kuna\Number\Tax(21));
-```
-
-Output
-
-```php
-
-// format 100 EUR like default to USD is set above
-$filters->format(100); // '125,00 USD'
-
-// count with VAT
-$filters->formatVat(100, 'usd', 'eur'); // '96.80 €'
-$filters->formatVatTo(100); // '151,25 USD'
-$filters->formatTo(100, 'CZK'); // '2 000,00 CZK'
-
-// Other options
-$filters->change(100, 'usd', 'eur'); // 80.0
-$filters->changeTo(100, 'usd'); // 125.0
-$filters->vat(100); // 121.0
-```
-
 ### Access and iterator
 
 ```php

diff --git a/changelog.md b/changelog.md
@@ -1,5 +1,10 @@
 # Changelog
 
+## v7.1
+
+- remove dependency on h4kuna/number-format
+- Formats.php and Filters.php moved [this extension](//github.com/h4kuna/exchange-nette)
+
 ## v7.0
 
 - your temporary rate implement by own RatingList

diff --git a/composer.json b/composer.json
@@ -14,7 +14,6 @@
   "require": {
     "php": ">=8.0",
     "arvenil/ninja-mutex": "^0.6",
-    "h4kuna/number-format": "^3.0",
     "h4kuna/serialize-polyfill": "^0.2",
     "psr/http-factory": "^1.0",
     "psr/simple-cache": "^3.0"

diff --git a/src/Currency/Formats.php b/src/Currency/Formats.php
diff --git a/src/Exchange.php b/src/Exchange.php
@@ -49,7 +49,6 @@ public function transfer(float $price, ?string $from = null, ?string $to = null)
 		}
 
 		$from = $this->ratingList->get()->offsetGet($from ?? $this->configuration->from);
-
 		if ($to !== $from) {
 			$price *= $from->rate / $to->rate;
 		}

diff --git a/src/Filters.php b/src/Filters.php
diff --git a/tests/src/Currency/FormatsTest.php b/tests/src/Currency/FormatsTest.php
diff --git a/tests/src/FiltersTest.php b/tests/src/FiltersTest.php
-Original file line number
+Diff line change
@@ Expand Up @@
     		}
     		$from = $this->ratingList->get()->offsetGet($from ?? $this->configuration->from);
     		if ($to !== $from) {
     			$price *= $from->rate / $to->rate;
     		}
@@ Expand Down @@