-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gwpy workarounds #11
Open
mikelovskij
wants to merge
73
commits into
master
Choose a base branch
from
gwpy-workarounds
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Gwpy workarounds #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctrogram in order to solve some issues with gwpy.
…d spectrograms, adjusted some identation.
…e middle the de-whitening filters are applied, and they need to be applied to the asd.
added some workaround to issues due to gwpy or to the nds library
Reference load fix develop
…s2 iteration fails. Could help with sudden and short fails happen.
…e_combination method.
Merged a bufix in the reference dictionary handling
… in order to represent titles legends etc correctly.
…ion of the iterator that happens because more time is required to perform an iteration than the interval of data used in such iteration, seems to be much less likely to happen.
…ill be skipped and skips to the first data available.
…ting smaller strides to the nds server than the ones required by the monitor, and then to append them, without having de sync between the various loops.
…n of the program didn't correspond to the epoch of the first retrieved data.
… a mismatch of self.epoch with the actual start of the data.
… after some attempts.
- Corrected the formatting of a warning message
…h other monitors. - Removed unused imports - Re-formatted some logger messages. -Added the windows and method options to the spectrogram calculation
…nded later because of the usual "ValueError: cannot resize this array: it does not own its data"
Reference load fix develop
Reference load fix develop
Nds fail handling develop
…o set different scales for different axes - Put the TimedAnimation refresh interval to 100, since the monitor will be timed by the nds2 iterator anyway.
- Modified the handling of the colorbar parameters, so that now they could the same format as the other parameters.
- Fixed the removal of additional titles and xlabels in the case multiple subplots are used. - In the case multiple subplot are used, not every subplots has a fake invisible colorbar so that the axes will be the same size of the axes of a spectrogram with the same figure size. - Re added the usage of channel.texname instead of channel.name since it seems that on computers with some latex versions installed it is required.
…alization of the monitors
…f the last channels, that caused the list of cparams to be shorter than the number of channels for that parameter, with a consequent indexerror when trying to access to the element of the list
…tor too. Solved a Bug that happened when using references and multiple separately subplotted spectra.
… separately subplotted spectra.
… evaulated data and new available data, in order to avoid weir errors difficoult to reproduce that happen when there's enough data to do another update cycle but for some reason the condition is not satisfied.
…et using the set_subtitle or set_suptitle methods.
Various fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just thinking that if random people want to test the tool, they will probably just download and install the master branch, which is quite behind with respect to this and less stable. Should we update it or do you prefer to test my modification a bit more before merging?