Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend channelnames fix #10

Open
wants to merge 18 commits into
base: gwpy-workarounds
Choose a base branch
from

Conversation

mikelovskij
Copy link
Contributor

Just some minor fixes:

  • Moved the wait time between one reconnection attempt and the other before the restart method, in order to use the re-created iterator just after its creation, since waiting between the creation of the object and the first iteration seems (especially if the wait is more than 30 second) to increase the possibility of failing to retrieve the data.
  • If vmin and vmax are not set and the colormap of a spectrogram changes due to an autoscale during the plotting, now the colorbar changes accordingly.
  • Solved a weird issue in the spectrum monitor: it happened that the first time the spectra were plotted, they were plotted in the wrong order, leading to wrong colors with respect to the ones set in the config file. After the first iteration, the spectra would have been replotted in the correct way, but the legend not, keeping the wrong colors. By changing the iterator from self.spectra to self.channels now the spectra are plotted in the correct order since the first iteration and the legend is created correctly.
  • Added the suptitle (with the plotting time) to the timeseries monitor.

…resh and then they remain wrong in the legend
…resh and then they remain wrong in the legend
… order to plot the channels in the correct order (hoping it will not break if a channel is missing in self.spectra)
…rmap is rescaled

- moved the .copy() of the specgram in the spectorgram buffer in order to perform it even if the data is not filtered
…e the reconnection instead of between the reconnection and the first usage of the recreated iterator, because it seems that waiting between the creation of the iterator and the actual usage of the iterator, makes failing in retrieving the data much more probable
…nd self.epoch changes for other reasons, to avoid deleting incorrectly plotted spectrograms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant