Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify mf_min #19

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

mj-will
Copy link
Contributor

@mj-will mj-will commented Aug 22, 2024

This PR adds the mf_min option to the plugin which is in turn passed to BBHx. When specified, all the caching in the plugin is skipped. This will be slower but should avoid any issues arising from using different ranges for interpolation.

I'm still testing this and I'll provide updates once I have some results.

@mj-will mj-will requested a review from WuShichao August 22, 2024 08:46
@mj-will
Copy link
Contributor Author

mj-will commented Aug 22, 2024

Here's a comparison between a run with mf_min=None and f_lower=1e-4 (blue) and mf_min=1e-5 and f_lower=1e-4` (orange).

image

@mj-will mj-will marked this pull request as ready for review August 22, 2024 13:42
Copy link
Collaborator

@WuShichao WuShichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@WuShichao WuShichao merged commit aaf6478 into gwastro:main Aug 22, 2024
3 checks passed
@mj-will mj-will mentioned this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants