Show emoji in agent status table (microsoft#444)

Also use fully qualified version of the greeting emoji to get the full-width in console.
gvanrossum-ms · Dec 2, 2024 · 5d832ba · 5d832ba
1 parent 6f49f48
commit 5d832ba
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 16 deletions.
diff --git a/ts/packages/agents/greeting/src/greetingManifest.json b/ts/packages/agents/greeting/src/greetingManifest.json
@@ -1,5 +1,5 @@
 {
-  "emojiChar": "🖐",
+  "emojiChar": "🖐️",
   "description": "Agent to generate greating messages",
   "schema": {
     "description": "Greeting agent that created personalized welcome messages.",

diff --git a/ts/packages/dispatcher/src/handlers/configCommandHandlers.ts b/ts/packages/dispatcher/src/handlers/configCommandHandlers.ts
@@ -244,12 +244,13 @@ function showAgentStatus(
     }
 
     const getRow = (
+        emoji: string,
         displayName: string,
         schemas?: string,
         actions?: string,
         commands?: string,
     ) => {
-        const displayEntry = [displayName];
+        const displayEntry = [emoji, displayName];
         if (showSchema) {
             displayEntry.push(schemas ?? "");
         }
@@ -263,16 +264,19 @@ function showAgentStatus(
     };
 
     const table: string[][] = [
-        getRow("Agent", "Schemas", "Actions", "Commands"),
+        getRow("", "Agent", "Schemas", "Actions", "Commands"),
     ];
 
     for (const [name, { schemas, actions, commands }] of entries) {
-        const displayName = getAppAgentName(name) !== name ? `  ${name}` : name;
-        table.push(getRow(displayName, schemas, actions, commands));
+        const isAppAgentName = getAppAgentName(name) === name;
+        const displayName = isAppAgentName ? name : `  ${name}`;
+        const emoji = isAppAgentName ? agents.getEmojis()[name] : "";
+        table.push(getRow(emoji, displayName, schemas, actions, commands));
     }
 
     displayResult(table, context);
 }
+
 class AgentToggleCommandHandler implements CommandHandler {
     public readonly description = `Toggle ${AgentToggleDescription[this.toggle]}`;
     public readonly parameters = {

diff --git a/ts/packages/dispatcher/src/utils/exceptions.ts b/ts/packages/dispatcher/src/utils/exceptions.ts
@@ -6,17 +6,7 @@ function throwEnsureError(e: any): never {
         throw new Error(e);
     }
     if (typeof e === "object") {
-        if (e instanceof Error) {
-            throw e;
-        }
-        const mayBeErrorLike = e as any;
-        if (
-            typeof mayBeErrorLike.name === "string" &&
-            typeof mayBeErrorLike.message === "string" &&
-            typeof mayBeErrorLike.stack === "string"
-        ) {
-            throw e;
-        }
+        throw e;
     }
     throw new Error(`Unknown error: ${JSON.stringify(e)}`);
 }