Added tests for DuplicatedImportError

gura/GuraParser.py

@@ -264,12 +264,11 @@ def __compute_imports(self, parent_dir_path: Optional[str]):
                     file_to_import = os.path.join(origin_file_path, file_to_import)
 
                 # Files can be imported only once. This prevents circular reference
-                # TODO: check how to report well the position and line
                 if file_to_import in self.imported_files:
                     raise DuplicatedImportError(
-                        self.pos + 1,
+                        self.pos - len(file_to_import) - 1,  # -1 for the quotes (")
                         self.line,
-                        f'The file {file_to_import} has been already imported'
+                        f'The file "{file_to_import}" has been already imported'
                     )
 
                 with open(file_to_import, 'r') as f:

tests/exception_report/test.py

@@ -120,9 +120,13 @@ def test_missing_variable_6(self):
         """Tests error position and line when user uses a non defined variable inside an import statement"""
         self.__test_fail('missing_variable_error_6.ura', VariableNotDefinedError, error_pos=21, error_line=0)
 
-    # def test_line_and_pos_6(self):
-    #     """Tests error position and line when imported files are duplicated"""
-    #     self.__test_fail('importing_error_1.ura', DuplicatedImportError, error_pos=20, error_line=2)
+    def test_duplicated_import_1(self):
+        """Tests error position and line when imported files are duplicated"""
+        self.__test_fail('importing_error_1.ura', DuplicatedImportError, error_pos=74, error_line=1)
+
+    def test_duplicated_import_2(self):
+        """Tests error position and line when imported files are duplicated but in other line than 0"""
+        self.__test_fail('importing_error_2.ura', DuplicatedImportError, error_pos=86, error_line=4)
 
 
 if __name__ == '__main__':

tests/exception_report/tests-files/importing_error_2.ura

@@ -0,0 +1,5 @@
+# COMMENT
+
+
+import "tests/importing/tests-files/duplicated_variable_aux_1.ura"
+import "tests/importing/tests-files/duplicated_variable_aux_1.ura"