Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Reset role blocks when model.reset is called #1073

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

hudson-ai
Copy link
Collaborator

Just empties the dict of open role blocks when model.reset is called. Should close #1071

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.98%. Comparing base (11892c2) to head (b3ef384).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
guidance/models/_model.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1073      +/-   ##
==========================================
- Coverage   65.35%   63.98%   -1.37%     
==========================================
  Files          65       65              
  Lines        4892     4893       +1     
==========================================
- Hits         3197     3131      -66     
- Misses       1695     1762      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nopdive
Copy link
Collaborator

nopdive commented Nov 6, 2024

LGTM.

@hudson-ai hudson-ai merged commit ed9f078 into guidance-ai:main Nov 7, 2024
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reset() does not work as expected in connection with role blocks
3 participants