Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keeping House] Split JSON tests into multiple files #1072

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

hudson-ai
Copy link
Collaborator

@riedgar-ms as per your suggestion, I have opened a separate PR for splitting the JSON tests into multiple files (and running black). I think we should probably go a step further, as I only moved the reference tests from the main test_json.py to test_refs.py so far.

Let's do that later so we can keep this minimal :)

P.S. I've already merged this locally with my other PR branch, so there will be no surprises or difficulties there.

@hudson-ai hudson-ai requested a review from riedgar-ms November 5, 2024 18:14
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.00%. Comparing base (b4b0047) to head (ed0a753).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
- Coverage   65.35%   64.00%   -1.35%     
==========================================
  Files          65       65              
  Lines        4892     4892              
==========================================
- Hits         3197     3131      -66     
- Misses       1695     1761      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hudson-ai hudson-ai merged commit 11892c2 into guidance-ai:main Nov 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants