Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bancos.csv #343

Closed
wants to merge 3 commits into from
Closed

Conversation

BrunoM90
Copy link
Contributor

@BrunoM90 BrunoM90 commented Dec 5, 2023

The websites of the following banks were added to the file:
-BNDES
-CREDICOAMO
-C.SUISSE HEDGING-GRIFFO CV S/A
-STATE STREET BR S.A. BCO COMERCIAL
-UBS BRASIL CCTVM S.A.
-CCM DESP TR NS SC E RS
-CONFIDENCE CC S.A.
-HAITONG BI DO BRASIL S.A.
-B&T CC LTDA.
-SISPRIME DO BRASIL - COOP
-COOPCENTRAL AILOS
-CREDISAN CC
-CCCM UNICRED CENTRAL RS
-BRK S.A. CFI
-POLOCRED SCMEPP LTDA.
-CREDISIS - CENTRAL DE COOPERATIVAS DE CRÉDITO LTDA. -CREDIALIANÇA CCR
-UNIPRIME COOPCENTRAL LTDA.
-PLANNER CV S.A.
-RENASCENCA DTVM LTDA
-XP INVESTIMENTOS CCTVM S/A
-LECCA CFI S.A.
-PORTOCRED S.A. - CFI
-OLIVEIRA TRUST DTVM S.A.
-NEON CTVM S.A.
-CENTRAL COOPERATIVA DE CRÉDITO NO ESTADO DO ESPÍRITO SANTO -ADVANCED CC LTDA
-BCO RNX S.A.

Issue #342

The websites of the following banks were added to the file:
-BNDES
-CREDICOAMO
-C.SUISSE HEDGING-GRIFFO CV S/A
-STATE STREET BR S.A. BCO COMERCIAL
-UBS BRASIL CCTVM S.A.
-CCM DESP TR NS SC E RS
-CONFIDENCE CC S.A.
-HAITONG BI DO BRASIL S.A.
-B&T CC LTDA.
-SISPRIME DO BRASIL - COOP
-COOPCENTRAL AILOS
-CREDISAN CC
-CCCM UNICRED CENTRAL RS
-BRK S.A. CFI
-POLOCRED SCMEPP LTDA.
-CREDISIS - CENTRAL DE COOPERATIVAS DE CRÉDITO LTDA.
-CREDIALIANÇA CCR
-UNIPRIME COOPCENTRAL LTDA.
-PLANNER CV S.A.
-RENASCENCA DTVM LTDA
-XP INVESTIMENTOS CCTVM S/A
-LECCA CFI S.A.
-PORTOCRED S.A. - CFI
-OLIVEIRA TRUST DTVM S.A.
-NEON CTVM S.A.
-CENTRAL COOPERATIVA DE CRÉDITO NO ESTADO DO ESPÍRITO SANTO
-ADVANCED CC LTDA
-BCO RNX S.A.
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@guibranco
Copy link
Owner

Hi @BrunoM90 first of all, thanks for the great pull request. I have one comment about it, you made your changes in the .csv file, but this file is generated automatically by the MergeTool.

The right place to make these changes is in the json file that the MergeTool uses as the source of truth.

Let me know if you are keen to contribute to that or I can merge this pull request and later make the changes in the proper file.

Copy link
Owner

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes will be overwritten by the next build. The proper file to do these changes is in the JSON file.

@BrunoM90
Copy link
Contributor Author

BrunoM90 commented Dec 8, 2023

Hi @guibranco.
Ok, I can contribute to that. I will send a new pull request.

@guibranco
Copy link
Owner

@BrunoM90 thanks!

@guibranco
Copy link
Owner

I'll close this one, since #344 was already approved.

@guibranco guibranco closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants