Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure installation cards have equal height #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Bekione
Copy link

@Bekione Bekione commented Dec 30, 2024

Description

Fixed an issue where installation cards(Next.js & Vite) had inconsistent heights when descriptions varied in length, causing uneven layout in the grid.

Changes Made

Added h-full class to the main card container in src/app/ui/installation/_components/Card.tsx to ensure all cards maintain equal height regardless of content length.

Before:

  • Cards had varying heights based on description length
  • This caused visual inconsistency in the grid layout

After:

  • All cards now maintain equal height
  • Grid layout appears more uniform and polished

Files Changed

  • src/app/ui/installation/_components/Card.tsx

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing

Verified that cards maintain equal height with different description lengths in both desktop and mobile views.

Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
luxe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 3:24pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant