Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies | December 5 2022 #2068

Closed
wants to merge 2 commits into from
Closed

Dependencies | December 5 2022 #2068

wants to merge 2 commits into from

Conversation

raphaelkabo
Copy link
Contributor

What does this change?

Changes from previous #2053:

  • Brings our dependencies up to the latest versions where possible
  • Replaces mjml-react, which is no longer under development, with the actively supported fork @faire/mjml-react.

Holds back the following:

  • Keeps react, react-dom and react-test-renderer at v17 because v18 will break IE11 support going forward
  • Keeps @types/react and @types/react-dom at v17 as v18 depends on React 18
  • Keeps @testing-library/react at v12 because v13 depends on React 18
  • Keeps @testing-library/react-hooks at v7 because v8 depends on React 18
  • Keeps @types/react-test-renderer and react-test-renderer at v17 because v18 depends on React 18

Tested

  • CODE
  • IE11

@raphaelkabo raphaelkabo requested a review from a team as a code owner December 5, 2022 13:27
@raphaelkabo
Copy link
Contributor Author

Looks like we need to keep this one back for the moment until this bug with Cypress gets resolved: cypress-io/cypress#24111

@raphaelkabo raphaelkabo closed this Dec 6, 2022
@raphaelkabo raphaelkabo deleted the rk/deps-2022-12-05 branch December 6, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant