Fix persisting of forced ab test to localstorage #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ad load time test resultsFor Test conditions:
|
emma-imber
approved these changes
Nov 12, 2024
| 1. Create a test in [src/experiments/tests](https://github.com/guardian/commercial-core/blob/main/src/experiments/tests) | ||
| 1. Add the test to [concurrent tests](https://github.com/guardian/commercial-core/blob/main/src/experiments/ab-tests.ts) | ||
| 1. Follow steps 1-6 in [the DCR documentation](https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/docs/development/ab-testing-in-dcr.md) | ||
| 1. Create a test in [src/experiments/tests](https://github.com/guardian/commercial/blob/main/src/experiments/tests) |
There was a problem hiding this comment.
Thanks for updating the docs! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This used to work, evidenced by the fact that
ab-localstorage.tsalready existed, and broke at some point.I'm not sure how leaving the test used to work but have modified slightly to allow leaving by clearing the variant e.g.
http://localhost:3030/Front/https://www.theguardian.com/uk#ab-yourTest=Why?
It's quite useful for the test to persist between pageviews.