Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving changesets to dev dependencies #1657

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rowannekabalan
Copy link

This dependency has turned up in the dependency tree on Frontend as it's in the dependencies list, however we think this is a dev dependency so we have moved it accordingly.

Co-authored-by: Dom Lander <[email protected]>
Co-authored-by: Jamie B <[email protected]>
Co-authored-by: Frederick O'Brien <[email protected]>
Co-authored-by: Marjan Kalanaki <[email protected]>
@rowannekabalan rowannekabalan requested a review from a team as a code owner November 12, 2024 14:27
Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: 5839b01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@domlander
Copy link
Contributor

domlander commented Nov 12, 2024

Changesets is a dev dependency in other Guardian repo's with no issues: https://github.com/search?q=org%3Aguardian+%22%40changesets%2Fcli%22%3A&type=code

Copy link
Contributor

Ad load time test results

For consented, top-above-nav took on average 5558ms to load.
For consentless, top-above-nav took on average 3050ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

Copy link
Contributor

@emma-imber emma-imber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just an FYI that you'll need to add a changeset if you want to release this change, or it'll just be included next time we bump the version - whatever works for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants