Elevator mech #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrolineCrois
reviewed
Dec 3, 2024
|
|
||
| public double position(){ | ||
| return encoder.getPosition(); | ||
| } |
There was a problem hiding this comment.
You should add a function to reset the encoder value to 0 when the elevator limit switch is triggered.
proan
approved these changes
Dec 10, 2024
Comment on lines
23
to
24
| leftelevator = new CANSparkMax (2, MotorType.kBrushless); | ||
| rightelevator = new CANSparkMax(3, MotorType.kBrushless); |
There was a problem hiding this comment.
It would be good to put these motor IDs into the constructor and use well-named constants for them, too. With the IDs buried here in the class, it makes it more difficult for seeing a system-level view. Ideally all motor ID assignments happen in a single configuration file. This makes it easier to change them.
Also, by moving the motor IDs into the constructor you can create multiple instances of this subsystem, should you need them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right bumper makes elevator go up and down