Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang and driver versions. #399

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Conversation

paulosjca
Copy link
Collaborator

@paulosjca paulosjca commented Nov 22, 2024

  • Updates the go version for tests that do not use prebuilt images to go 1.23.
  • Updates the go version for github actions to 1.21.x (build currently fails with go version >= 1.22.0).
  • Updates the go version for the controller build to 1.21.
  • Updates the driver version to (grpc) 1.68.0.

This change updates the go version for tests that do not use prebuilt
images to go 1.22.
@paulosjca paulosjca added the release notes: yes Indicates that PR needs to be in release notes label Nov 22, 2024
@paulosjca paulosjca requested a review from veblush November 22, 2024 00:27
@paulosjca paulosjca self-assigned this Nov 22, 2024
Build currently fails with go version >= 1.22.0.
@paulosjca paulosjca changed the title Update golang version for regular tests to go1.22. Update golang versions for regular tests and github actions. Nov 22, 2024
@paulosjca paulosjca requested review from drfloob and gnossen November 22, 2024 00:45
@paulosjca paulosjca changed the title Update golang versions for regular tests and github actions. Update golang and driver versions. Nov 22, 2024
@paulosjca paulosjca marked this pull request as draft November 22, 2024 01:23
@paulosjca paulosjca requested a review from arjan-bal November 22, 2024 03:36
    This change updates the go version for tests that do not use prebuilt
    images to go 1.23.
Copy link

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, optional comment about using a newer buildImage for Go.

@paulosjca paulosjca marked this pull request as ready for review November 22, 2024 03:55
@paulosjca paulosjca merged commit c877bd8 into grpc:master Nov 22, 2024
2 checks passed
@paulosjca paulosjca deleted the goversion2 branch November 22, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: yes Indicates that PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants