Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: update proto generation command #17

Merged
merged 1 commit into from
Jan 5, 2024
Merged

README.md: update proto generation command #17

merged 1 commit into from
Jan 5, 2024

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented Jan 3, 2024 •
edited
Loading

Note this also adds --pyi_out=. to generate Python pyi stub for dev convenience.

@sergiitk sergiitk requested a review from XuanWang-Amos January 3, 2024 22:37
@sergiitk
Copy link
Member Author

sergiitk commented Jan 3, 2024

cc @stanley-cheung

@sergiitk sergiitk enabled auto-merge (squash) January 3, 2024 22:38
@sergiitk sergiitk disabled auto-merge January 3, 2024 22:38
@sergiitk sergiitk enabled auto-merge (squash) January 3, 2024 22:39
stanley-cheung
stanley-cheung approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's exactly what fixed it for me as well.

@sergiitk sergiitk requested review from gnossen and removed request for XuanWang-Amos January 5, 2024 20:42
@sergiitk sergiitk merged commit fed0e62 into grpc:main Jan 5, 2024
6 checks passed
@sergiitk sergiitk deleted the update-readme branch January 5, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanley-cheung stanley-cheung stanley-cheung approved these changes

@gnossen gnossen gnossen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergiitk @gnossen @stanley-cheung