Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor: Use native TypeAlias #135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

minor: Use native TypeAlias #135

wants to merge 1 commit into from

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented Oct 8, 2024

TypeAlias was added in 3.10, so now we don't need to import it from typing_extensions anymore.

Updating it now everywhere so that the old-style import doesn't spread by-copypasting.

@sergiitk
Copy link
Member Author

sergiitk commented Oct 9, 2024 •
edited
Loading

Superseded by #136.

Not anymore, this should be merged first.

@sergiitk sergiitk closed this Oct 9, 2024
@sergiitk sergiitk deleted the native-typealias branch October 9, 2024 19:10
@sergiitk sergiitk restored the native-typealias branch October 9, 2024 20:21
@sergiitk sergiitk reopened this Oct 9, 2024
@sergiitk sergiitk marked this pull request as ready for review October 9, 2024 20:22
@sergiitk sergiitk requested a review from a team as a code owner October 9, 2024 20:22
@sergiitk sergiitk requested a review from XuanWang-Amos October 9, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuanWang-Amos XuanWang-Amos XuanWang-Amos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergiitk @XuanWang-Amos