Add CI actions #11
Merged
Add CI actions #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiitk
requested changes
Nov 20, 2023
.github/workflows/psm-interop.yaml
Outdated
| run: > | ||
| python -m grpc_tools.protoc --proto_path=. | ||
| --python_out=. --grpc_python_out=. | ||
| protos/empty.proto |
There was a problem hiding this comment.
We probably should keep the packages path after protos/: protos/grpc/testing.
@gnossen - curious what you'd recommend here. Does the path really matter?
There was a problem hiding this comment.
What's the benefits of keeping it? I thought those are just paths to the .proto files.
There was a problem hiding this comment.
They do declare package grpc.testing;, and IRRC file path should correspond to the packages.
In practice, this means that the imports will look different:
from protos.grpc.testing import messages_pb2instead of
from protos import messages_pb2Then if we need to embed other protos (f.e. xds), they'd be in their own package too
There was a problem hiding this comment.
Checked with Richard offline, it's better to move them to correct location.
|
Thank you so much, @XuanWang-Amos, this looks great! Just left some minor notes. |
sergiitk
reviewed
Nov 20, 2023
sergiitk
reviewed
Nov 21, 2023
sergiitk
reviewed
Nov 21, 2023
sergiitk
reviewed
Nov 21, 2023
sergiitk
reviewed
Dec 5, 2023
sergiitk
added a commit
that referenced
this pull request
Dec 8, 2023
* Revert "Remove unreviewed changes (#10)" This reverts commit 7b0e3f1. * Changes for this repo * Fix indent issue * Try not install Python for pylint * Remove strategy * Remvoe name * Changes from comments * Try fix path issue * Move .pylintrc-tests back to root * Use two steps for pylint * try pylint in another folder * Try rename black.toml to pyproject.toml * Move protos * Fix proto path * Changes based on comments --------- Co-authored-by: Sergii Tkachenko <[email protected]>
sergiitk
added a commit
that referenced
this pull request
Dec 8, 2023
* Revert "Remove unreviewed changes (#10)" This reverts commit 7b0e3f1. * Changes for this repo * Fix indent issue * Try not install Python for pylint * Remove strategy * Remvoe name * Changes from comments * Try fix path issue * Move .pylintrc-tests back to root * Use two steps for pylint * try pylint in another folder * Try rename black.toml to pyproject.toml * Move protos * Fix proto path * Changes based on comments --------- Co-authored-by: Sergii Tkachenko <[email protected]>
sergiitk
added a commit
that referenced
this pull request
Dec 8, 2023
* Revert "Remove unreviewed changes (#10)" This reverts commit 7b0e3f1. * Changes for this repo * Fix indent issue * Try not install Python for pylint * Remove strategy * Remvoe name * Changes from comments * Try fix path issue * Move .pylintrc-tests back to root * Use two steps for pylint * try pylint in another folder * Try rename black.toml to pyproject.toml * Move protos * Fix proto path * Changes based on comments --------- Co-authored-by: Sergii Tkachenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
unittest,black,isortandpylintcheck to GitHub actions.