Dualstack test case #108
Merged
Dualstack test case #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiitk
reviewed
Jul 27, 2024
larry-safran
force-pushed
the
dualstack_test
branch
2 times, most recently
from
4f726ce to
f5e643c
Compare
Needed so we can assign workloads from separate deployments to the same service, therefore the same NEG.
This reverts commit f569189.
… some servers binding only 1 ip version.
… the service is created as IPv4 Only) and addressed a code review cleanup comment.
larry-safran
force-pushed
the
dualstack_test
branch
from
f5e643c to
e927382
Compare
…ified. This is only needed after aborting a run that had created a client before it could cleanup.
sergiitk
reviewed
Jul 31, 2024
sergiitk
reviewed
Jul 31, 2024
sergiitk
reviewed
Jul 31, 2024
|
Previous test runs passed, deflaking CSM: |
sergiitk
approved these changes
Jul 31, 2024
|
Re deflaking CSM: I just realized the grpcroute test is now expected to fail, so Arvin added a temporary skip in another PR. So no need to wait for the other adhoc run to finish. |
Co-authored-by: Sergii Tkachenko <[email protected]>
sergiitk
reviewed
Jul 31, 2024
sergiitk
reviewed
Jul 31, 2024
Co-authored-by: Sergii Tkachenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have a test case that initializes 3 servers. They will each have different --address_type arguments from: "ipv4_ipv6", "ipv4", "ipv6". It will then create a client and run the round robin test ensuring that all 3 receive traffic. Due to warmup, we aren't concerned about equal traffic.
Once Java 1.66 is cut, update canonical server to point to it so that it has support for the address_type argument