-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L120: Transition to Modern C++ #460
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
L120-requiring-cpp17.md
Outdated
|
||
## Abstract | ||
|
||
gRPC starts requiring C++17. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to have to keep publishing new gRFCs every time we add support for a new version of C++, or do we just want to publish a gRFC that says "from now on, we'll follow the OSS foundational C++ support policy"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good point. Our plan is to keep up with the OSS foundational C++ support policy so we can have this last gRFC making it clear and skip new gRFC for the next bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned the future plan at the bottom. PTAL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is actually our plan going forward, then I think we should re-title this gRFC -- it's less about C++17 specifically than it is about the fact that we're now going to follow the OSS foundational C++ support guidelines.
Maybe this warrants a brief discussion at our Tuesday design review meeting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. I changed it and I'll bring this up in the next design meeting.
Are we going to allow, e.g., to |
This topic is beyond the scope of this doc but that should be communicated well within the maintainers. Abseil by default makes |
grpc/grpc#37930 just got merged to prevent accidental use of |
No description provided.