Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L120: Transition to Modern C++ #460

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

L120: Transition to Modern C++ #460

wants to merge 6 commits into from

Conversation

veblush
Copy link
Contributor

@veblush veblush commented Oct 14, 2024

No description provided.

Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

L120-requiring-cpp17.md Outdated Show resolved Hide resolved

## Abstract

gRPC starts requiring C++17.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to have to keep publishing new gRFCs every time we add support for a new version of C++, or do we just want to publish a gRFC that says "from now on, we'll follow the OSS foundational C++ support policy"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good point. Our plan is to keep up with the OSS foundational C++ support policy so we can have this last gRFC making it clear and skip new gRFC for the next bump.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned the future plan at the bottom. PTAL.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is actually our plan going forward, then I think we should re-title this gRFC -- it's less about C++17 specifically than it is about the fact that we're now going to follow the OSS foundational C++ support guidelines.

Maybe this warrants a brief discussion at our Tuesday design review meeting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. I changed it and I'll bring this up in the next design meeting.

@eugeneo
Copy link
Contributor

eugeneo commented Oct 14, 2024

Are we going to allow, e.g., to std::string_view from absl::string_view? Should this gRFC mention this?

@veblush
Copy link
Contributor Author

veblush commented Oct 14, 2024

Are we going to allow, e.g., to std::string_view from absl::string_view? Should this gRFC mention this?

This topic is beyond the scope of this doc but that should be communicated well within the maintainers. Abseil by default makes absl::string_view an alias of std::string_view under C++17 but it still provides an opt-in build option to use their own implementation. Hence, to support this build option, gRPC will have to stick to absl::string_view until we stop supporting this option.

@veblush
Copy link
Contributor Author

veblush commented Oct 16, 2024

Are we going to allow, e.g., to std::string_view from absl::string_view? Should this gRFC mention this?

This topic is beyond the scope of this doc but that should be communicated well within the maintainers. Abseil by default makes absl::string_view an alias of std::string_view under C++17 but it still provides an opt-in build option to use their own implementation. Hence, to support this build option, gRPC will have to stick to absl::string_view until we stop supporting this option.

grpc/grpc#37930 just got merged to prevent accidental use of std::string_view in the future.

@veblush veblush changed the title L120: Requiring C++17 L120: Transition to Modern C++ Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants