A66 and A78 update: Add value type (integer/floating-point) to metrics #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdroth
changed the title
markdroth
reviewed
Jun 5, 2024
| * Implemented in: <language, ...> | ||
| * Last updated: 2024-04-08 | ||
| * Discussion at: https://groups.google.com/g/grpc-io/c/A2Mqz8OMDys | ||
| ## A78: gRPC OTel Metrics for WRR, Pick First, and XdsClient |
There was a problem hiding this comment.
Can you please undo the reformatting here? This makes it really hard to see what's actually changed.
| @@ -406,22 +407,22 @@ the data. | |||
| * **grpc.client.attempt.started** <br> | |||
| The total number of RPC attempts started, including those that have not completed. <br> | |||
| *Attributes*: grpc.method, grpc.target <br> | |||
| *Type*: Counter <br> | |||
| *Type*: Counter (integer) <br> | |||
There was a problem hiding this comment.
I think we might want to say something more precise than just "integer" vs. "floating point". For example, would it be okay for a gRPC implementation to use a 32-bit integer here? I assume not, in which case we need language here saying so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.