This repository has been archived by the owner on Apr 9, 2021. It is now read-only.
update grpc stacks comments #793
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apolcyn
approved these changes
Dec 11, 2018
|
|
||
| <!--more--> | ||
|
|
||
| There are three main stacks in gRPC: C-core, Go, and Java. Most of the languages are thin wrappers on top of the [C-based](https://github.com/grpc/grpc/tree/master/src/core) gRPC core library: | ||
| There are three main language stacks in gRPC: C-core, Go, and Java. Most of the languages are thin wrappers on top of the [C-based](https://github.com/grpc/grpc/tree/master/src/core) gRPC core library: |
There was a problem hiding this comment.
nit: maybe something like "most of the user-facing language surface APIs", instead of "most of the languages". Otherwise, it's maybe a little confusing since "language stacks" including C-core, and then most "languages" are built on C-core
|
@carl-mastrangelo should we close this one? |
|
@thisisnotapril maybe approve it? |
|
@carl-mastrangelo that works too; wasn't sure what the status was given the age. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @sanjaypujare @apolcyn