Expose getName() in MethodDescriptor and fix TS definitions. (#1289)

grpc · Sep 30, 2022 · 4974a7b · 4974a7b
1 parent ac17547
commit 4974a7b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 11 deletions.
diff --git a/javascript/net/grpc/web/methoddescriptor.js b/javascript/net/grpc/web/methoddescriptor.js
@@ -74,6 +74,7 @@ const MethodDescriptor = class {
 
   /**
    * @override
+   * @export
    */
   getName() {
     return this.name;

diff --git a/packages/grpc-web/externs.js b/packages/grpc-web/externs.js
@@ -32,3 +32,6 @@ module.UnaryResponse.prototype.getResponseMessage = function() {};
 module.UnaryResponse.prototype.getMetadata = function() {};
 module.UnaryResponse.prototype.getMethodDescriptor = function() {};
 module.UnaryResponse.prototype.getStatus = function() {};
+
+module.MethodDescriptor = function() {};
+module.MethodDescriptor.getName = function() {};
diff --git a/packages/grpc-web/index.d.ts b/packages/grpc-web/index.d.ts
@@ -75,18 +75,7 @@ declare module "grpc-web" {
                 responseType: new (...args: unknown[]) => RESP,
                 requestSerializeFn: any,
                 responseDeserializeFn: any);
-    createRequest(requestMessage: REQ,
-                  metadata?: Metadata,
-                  callOptions?: CallOptions): Request<REQ, RESP>;
-    createUnaryResponse(responseMessage: RESP,
-                        metadata?: Metadata,
-                        status?: Status): UnaryResponse<REQ, RESP>;
     getName(): string;
-    getMethodType(): string;
-    getRequestMessageCtor(): new (...args: unknown[]) => REQ;
-    getResponseMessageCtor(): new (...args: unknown[]) => RESP;
-    getRequestSerializeFn(): any;
-    getResponseDeserializeFn(): any;
   }
 
   export class Request<REQ, RESP> {