Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to reflect codegen changes #4

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Sep 24, 2024

Motivation:

The names of generated types was changed in the upstream code gen module so our tests now fail.

Modifications:

  • Update generated tests.

Result:

  • Tests pass

Motivation:

The names of generated types was changed in the upstream code gen
module so our tests now fail.

Modifications:

- Update generated tests.

Result:

- Tests pass
@glbrntt
Copy link
Collaborator Author

glbrntt commented Sep 24, 2024

Depends on grpc/grpc-swift#2072

@glbrntt glbrntt added the ⚠️ semver/major Breaks existing public API. label Sep 24, 2024
@glbrntt glbrntt marked this pull request as ready for review September 25, 2024 09:15
@glbrntt glbrntt requested a review from gjcairo September 25, 2024 14:12
@glbrntt glbrntt enabled auto-merge (squash) September 25, 2024 14:12
@glbrntt glbrntt merged commit beda008 into grpc:main Sep 30, 2024
3 of 4 checks passed
@glbrntt glbrntt deleted the underscore_in_codegen branch September 30, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ semver/major Breaks existing public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants