Make check for bundled protos more resilient #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The fix in grpc#17 relies on `SwiftProtobufPluginLibrary`'s `WellKnownType` type including all protos bundled by `SwiftProtobuf`, this turns out not to be true so in some case (like using the "Empty" proto) an import was missing. Modifications: - Use the "isBundleProto" API which better suits our needs - Update test to use type which would fail test before fix Result: Better code gen
gjcairo
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The fix in #17 relies on
SwiftProtobufPluginLibrary'sWellKnownTypetype including all protos bundled bySwiftProtobuf, this turns out not to be true so in some case (like using the "Empty" proto) an import was missing.Modifications:
Result:
Better code gen