grpc-js-xds: Use TypeScript 5 #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiitk
approved these changes
Mar 27, 2024
|
It looks like that change affected the build process, so I just updated the interop Dockerfile to handle it. |
This was referenced Mar 29, 2024
|
ref b/331625445 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change here is to upgrade from TypeScript 4 to TypeScript 5 in the
@grpc/grpc-js-xdspackage. This fixes an issue where the generated code changes from #2693 would not be accepted by the compiler.I also modified
grpc-jsso that it uses the local copy ofproto-loader, to avoid delays in detecting these issues, and I updated the committed copy of the generated code.