Switch to bazelmod #618
Switch to bazelmod #618
Conversation
|
@ratnikov I was just lurking on the issue that this patch is targeted towards. Is there an alternative/competing patch thats not listed on the issue? Nice work regardless, it would be good to see bzlmod support. Hopefully you're able to get the CLA and stuff and find a reviewer 😄 🤞 |
|
I'm not aware of any alternative work. I've been using my patch internally for a bit, so so far it works. :) We've been making some progress on our end to get the EasyCLA hurdle out of the way, so I'm hopping that that will be green in a week or two. I have a feeling that may elicit some input from maintainers on its mergability. |
|
Is anything blocking review of this? It seems the CLA has been signed. |
|
@lowasser hey, looks like you merged last few commits. Could you help me understand what's the best process to follow to proceed with the review of this PR? |
Following rules_java example seems sane to me: https://github.com/bazelbuild/rules_java/blob/master/.gitignore#L20
|
Ready to merge? |
|
@gonzojive Yes. Waiting for maintainers to take action and unblock running of the checks (or unblock merging in a different way). |
Resolves #398
I'm open to which version to pick, just happy I can depend on grpc-kotlin using bazel mod. :)