bazel: Restore DoNotCall ErrorProne check #11774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In e08b9db we added `@DoNotCall` annotations to some call sites, but Bazel used an older version of ErrorProne that complained at times it shouldn't. The minimum version of Bazel we test/support is now Bazel 6, well past Bazel 3.4+.
larry-safran
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In e08b9db we added
@DoNotCallannotations to some call sites, but Bazel used an older version of ErrorProne that complained at times it shouldn't. The minimum version of Bazel we test/support is now Bazel 6, well past Bazel 3.4+.