rls: Reduce RLS channel logging #11709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The channel log is shared by many components and is poorly suited to the noise of per-RPC events. This commit restricts RLS usage of the logger to no more frequent than cache entry events. This may still be too frequent, but should substantially improve the signal-to-noise and we can do further rework as needed. Many of the log entries were poor because they lacked enough context. They weren't even clear they were from RLS. The cache entry events now regularly include the request key in the logs, allowing you to follow events for specific keys. I would have preferred using the hash code, but NumberFormat is annoying and toString() may be acceptable given its convenience. This commit reverts much of eba699a. Those logs have not proven to be helpful as they produce more output than can be reasonably stored.
larry-safran
approved these changes
Nov 26, 2024
larry-safran
approved these changes
Nov 27, 2024
larry-safran
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The channel log is shared by many components and is poorly suited to the noise of per-RPC events. This commit restricts RLS usage of the logger to no more frequent than cache entry events. This may still be too frequent, but should substantially improve the signal-to-noise and we can do further rework as needed.
Many of the log entries were poor because they lacked enough context. They weren't even clear they were from RLS. The cache entry events now regularly include the request key in the logs, allowing you to follow events for specific keys. I would have preferred using the hash code, but NumberFormat is annoying and toString() may be acceptable given its convenience.
This commit reverts much of eba699a. Those logs have not proven to be helpful as they produce more output than can be reasonably stored.
CC @DNVindhya