Allow to send empty subscription and update version afterward (1.66.x backport) #11435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11232
As described in the original issue:
If a CDS update revoke all subscribed resources, all EDS subscriptions will be cancelled.
adjustResourceSubscription issue
The first observation of the
istiod
logs is,If EDS is empty,
adjustResourceSubscription
does not work.resourceVersion update issue
If all resources are removed from a type, e.g. EDS,
subscribedResourceTypeUrls
entry will be also removed. This will prevent nonce being updated from the upstream EDS PUSH.Backport of #11264