Fix spm load time #236
Merged
Fix spm load time #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannahShiSFB
approved these changes
Mar 10, 2024
|
Thanks for the effort. I'll create a new release soon. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce SPM load time from 20 minutes to about 10 seconds.
10 seconds is still not good enough for a single library, but probably ok for the upcoming release.
More speedups may be possible by further consolidating only needed files to a single source directory for SPM.
Note that https://github.com/grpc/grpc-ios/actions/runs/8217485955 is now 19 minutes versus times ranging from 33 to 71 minutes for previous runs.
Firebase/Firestore integration testing in firebase/firebase-ios-sdk#12508. The spm-source tests pass in https://github.com/firebase/firebase-ios-sdk/actions/runs/8217864323/job/22474043936?pr=12508
This PR also eliminates the symbolic linking of Package.swift because integration testing was failing because SPM does not support symbolic links: