Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build and add CI #218

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Fix build and add CI #218

merged 3 commits into from
Oct 27, 2023

Conversation

paulb777
Copy link
Collaborator

Fix SPM build issues and add CI for future regression testing

Screenshot 2023-10-23 at 4 07 59 PM

@paulb777
Copy link
Collaborator Author

@sampajano Would appreciate your team's review, merge, and 1.49.2 tag to fix the SPM build issues. And also to carry the fixes and CI forward to future releases.

cc: @ncooke3 @wu-hui

@sampajano sampajano assigned HannahShiSFB and unassigned sampajano Oct 24, 2023
@sampajano
Copy link
Collaborator

@paulb777 Thanks for filing the issue!

I suppose this was the same one we've been discussion? i.e. regarding use_frameworks?

@paulb777
Copy link
Collaborator Author

@sampajano No, this is different. use_frameworks! is a CocoaPods issue. This PR fixes the Swift Package Manager build and adds CI to help keep it working.

@sampajano
Copy link
Collaborator

@paulb777 Oh! Sorry i didn't look closely!

Thanks so much for adding the CI for us!!

This looks great!

@HannahShiSFB PTAL too!

Copy link
Collaborator

@sampajano sampajano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the new CI!

@HannahShiSFB PTAL — i suppose this fills in some holes which we have today. If we have more similar holes (i.e. build tests), we should fill them too. Thanks!

@sampajano sampajano merged commit da8a240 into grpc_release_1.49.x Oct 27, 2023
3 checks passed
@sampajano sampajano deleted the pb-149-link-errors branch October 27, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants