Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native] 32bit conversion warning fix for gRPC C-Core #109

Merged
merged 1 commit into from
Jun 22, 2022
Merged

[native] 32bit conversion warning fix for gRPC C-Core #109

merged 1 commit into from
Jun 22, 2022

Conversation

dennycd
Copy link
Contributor

@dennycd dennycd commented Jun 22, 2022 •
edited
Loading

This patch fixed 32bit conversion warning (-Wshorten-64-to-32) as seem from default SPM build in gRPC C-Core native source.

Build Test Verification

Run SPM sample app build with -Wshorten-64-to-32 turned on 
./scripts/./build_test_spm_samples.sh

cc @HannahShiSFB @sampajano

@dennycd dennycd added kind/release Release process area/spm Swift Package Manager Support labels Jun 22, 2022
@dennycd dennycd enabled auto-merge (squash) June 22, 2022 04:01
@dennycd dennycd merged commit 8440b91 into grpc:grpc_release_1.44.0 Jun 22, 2022
sampajano
sampajano approved these changes Jun 22, 2022
View reviewed changes
Copy link
Collaborator

@sampajano sampajano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampajano sampajano sampajano approved these changes

@HannahShiSFB HannahShiSFB Awaiting requested review from HannahShiSFB

Assignees
No one assigned
Labels
area/spm Swift Package Manager Support kind/release Release process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennycd @sampajano