cleanup: replace dial with newclient #7970
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7970 +/- ##
==========================================
+ Coverage 82.05% 82.15% +0.10%
==========================================
Files 381 381
Lines 38539 38542 +3
==========================================
+ Hits 31622 31665 +43
+ Misses 5602 5567 -35
+ Partials 1315 1310 -5
|
arjan-bal
reviewed
Dec 26, 2024
interop/alts/client/client.go
Outdated
| if err != nil { | ||
| logger.Fatalf("gRPC Client: failed to dial the server at %v: %v", *serverAddr, err) | ||
| logger.Fatalf("gRPC Client: NewClient() failed %v: %v", *serverAddr, err) |
There was a problem hiding this comment.
Suggested change
| logger.Fatalf("gRPC Client: NewClient() failed %v: %v", *serverAddr, err) | |
| logger.Fatalf("gRPC Client: failed to create a client for server at %q: %v", *serverAddr, err) |
interop/client/client.go
Outdated
| if err != nil { | ||
| logger.Fatalf("Fail to dial: %v", err) | ||
| logger.Fatalf("NewClient() failed: %v", err) |
There was a problem hiding this comment.
Suggested change
| logger.Fatalf("NewClient() failed: %v", err) | |
| logger.Fatalf("Failed to create a client: %v", err) |
| if err != nil { | ||
| errorLog.Fatalf("Fail to dial: %v", err) | ||
| errorLog.Fatalf("NewClient() failed: %v", err) |
There was a problem hiding this comment.
Suggested change
| errorLog.Fatalf("NewClient() failed: %v", err) | |
| errorLog.Fatalf("Failed to create a client: %v", err) |
| if err != nil { | ||
| logger.Fatalf("Fail to dial: %v", err) | ||
| logger.Fatalf("NewClient() failed: %v", err) |
There was a problem hiding this comment.
Suggested change
| logger.Fatalf("NewClient() failed: %v", err) | |
| logger.Fatalf("Failed to create a client: %v", err) |
| if err != nil { | ||
| log.Fatalf("Fail to dial: %v", err) | ||
| log.Fatalf("NewClient() failed: %v", err) |
There was a problem hiding this comment.
Suggested change
| log.Fatalf("NewClient() failed: %v", err) | |
| log.Fatalf("Failed to create a client: %v", err) |
interop/xds/client/client.go
Outdated
| if err != nil { | ||
| logger.Fatalf("Fail to dial: %v", err) | ||
| logger.Fatalf("NewClient() failed: %v", err) |
There was a problem hiding this comment.
Suggested change
| logger.Fatalf("NewClient() failed: %v", err) | |
| logger.Fatalf("Failed to create a client: %v", err) |
interop/xds_federation/client.go
Outdated
| if err != nil { | ||
| logger.Fatalf("Fail to dial %v: %v", uris[i], err) | ||
| logger.Fatalf("NewClient() failed %v: %v", uris[i], err) |
There was a problem hiding this comment.
Suggested change
| logger.Fatalf("NewClient() failed %v: %v", uris[i], err) | |
| logger.Fatalf("Failed to create a client for server %q: %v", uris[i], err) |
profiling/cmd/remote.go
Outdated
| if err != nil { | ||
| logger.Errorf("cannot dial %s: %v", *flagAddress, err) | ||
| logger.Errorf("NewClient() failed %s: %v", *flagAddress, err) |
There was a problem hiding this comment.
Suggested change
| logger.Errorf("NewClient() failed %s: %v", *flagAddress, err) | |
| logger.Fatalf("Failed to create a client for server %q: %v", *flagAddress, err) |
resolver/manual/manual.go
Outdated
| @@ -110,7 +110,7 @@ func (r *Resolver) UpdateState(s resolver.State) { | |||
| defer r.mu.Unlock() | |||
| var err error | |||
| if r.CC == nil { | |||
| panic("cannot update state as grpc.Dial with resolver has not been called") | |||
| panic("cannot update state as grpc.NewClient with resolver has not been called") | |||
There was a problem hiding this comment.
cannot update state as channel has not exited IDLE state
Update throughout.
| @@ -260,10 +260,11 @@ func (lb *lbBalancer) newRemoteBalancerCCWrapper() error { | |||
| // The grpclb server addresses will set field ServerName, and creds will | |||
| // receive ServerName as authority. | |||
| target := lb.manualResolver.Scheme() + ":///grpclb.subClientConn" | |||
| cc, err := grpc.Dial(target, dopts...) | |||
| cc, err := grpc.NewClient(target, dopts...) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address: #7049
RELEASE NOTES: None