Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leastrequest: Delegate subchannel creation to pickfirst #7969

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arjan-bal
Copy link
Contributor

This PR switches the least request balancer to defer to pick first instead of creating and handling SubConns itself. This is part of Dualstack, and makes this a petiole.

RELEASE NOTES:

  • balancer/leastrequest: Least request uses pick first child policies to manage endpoints instead of creating SubConns.
  • balancer/leastrequest: Least request uses the Endpoints field instead of the Addresses field in resolver state updates.

@arjan-bal arjan-bal added Type: Feature New features or improvements in behavior Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. labels Dec 26, 2024
@arjan-bal arjan-bal added this to the 1.70 Release milestone Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 80.43478% with 18 lines in your changes missing coverage. Please review.

Project coverage is 82.10%. Comparing base (724f450) to head (1fcd5db).

Files with missing lines Patch % Lines
balancer/leastrequest/leastrequest.go 80.43% 13 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7969      +/-   ##
==========================================
+ Coverage   82.05%   82.10%   +0.05%     
==========================================
  Files         381      381              
  Lines       38539    38585      +46     
==========================================
+ Hits        31622    31680      +58     
+ Misses       5602     5589      -13     
- Partials     1315     1316       +1     
Files with missing lines Coverage Δ
balancer/leastrequest/leastrequest.go 81.60% <80.43%> (-5.75%) ⬇️

... and 17 files with indirect coverage changes

@arjan-bal arjan-bal requested a review from dfawley December 26, 2024 04:08
@arjan-bal arjan-bal added Type: Internal Cleanup Refactors, etc and removed Type: Feature New features or improvements in behavior labels Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. Type: Internal Cleanup Refactors, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants