Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: replace dial with newclient #7943

Merged
merged 9 commits into from
Dec 23, 2024
Merged

cleanup: replace dial with newclient #7943

merged 9 commits into from
Dec 23, 2024

Conversation

janardhanvissa
Copy link
Contributor

@janardhanvissa janardhanvissa commented Dec 18, 2024 •
edited
Loading

Partially address: #7049

RELEASE NOTES: None

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.15%. Comparing base (e5a4eb0) to head (77d8456).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7943      +/-   ##
==========================================
- Coverage   82.21%   82.15%   -0.07%     
==========================================
  Files         379      381       +2     
  Lines       38261    38535     +274     
==========================================
+ Hits        31458    31657     +199     
- Misses       5514     5573      +59     
- Partials     1289     1305      +16

see 29 files with indirect coverage changes

@arjan-bal arjan-bal self-requested a review December 20, 2024 08:24
@arjan-bal arjan-bal self-assigned this Dec 20, 2024
arjan-bal
arjan-bal reviewed Dec 23, 2024
View reviewed changes
internal/idle/idle_e2e_test.go Outdated Show resolved Hide resolved
orca/producer_test.go Outdated Show resolved Hide resolved
orca/producer_test.go Outdated Show resolved Hide resolved
resolver/manual/manual_test.go Outdated Show resolved Hide resolved
test/authority_test.go Outdated Show resolved Hide resolved
test/roundrobin_test.go Outdated Show resolved Hide resolved
@arjan-bal arjan-bal added Type: Internal Cleanup Refactors, etc Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. labels Dec 23, 2024
@arjan-bal arjan-bal added this to the 1.70 Release milestone Dec 23, 2024
arjan-bal
arjan-bal approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

arjan-bal
arjan-bal reviewed Dec 23, 2024
View reviewed changes
test/authority_test.go Outdated Show resolved Hide resolved
@arjan-bal arjan-bal requested a review from dfawley December 23, 2024 09:21
@dfawley dfawley merged commit 681334a into grpc:master Dec 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjan-bal arjan-bal arjan-bal approved these changes

@dfawley dfawley dfawley approved these changes

Assignees

@dfawley dfawley

Labels
Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.70 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@janardhanvissa @dfawley @arjan-bal @janardhankrishna-sai