test: Add a test for decompression exceeding max receive message size #7938
Conversation
arjan-bal
added
Type: Testing
Area: RPC Features
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7938 +/- ##
==========================================
- Coverage 82.08% 82.01% -0.07%
==========================================
Files 379 379
Lines 38261 38261
==========================================
- Hits 31406 31381 -25
- Misses 5551 5569 +18
- Partials 1304 1311 +7 |
| // Use the name of an existing compressor to avoid interactions with other | ||
| // tests since compressors can't be un-registered. | ||
| return "gzip" |
There was a problem hiding this comment.
Can we use t.Name as the name for the compressor and thereby avoid interactions with other tests?
There was a problem hiding this comment.
I tried this earlier, but the clients in the following test pick up the registered compressor and start failing.
grpc-go/test/compressor_test.go
Line 617 in e8055ea
There's no way to unregister a compressor presently. There is a deprecated WithCompressor that allows using a compressor without registration that I can use.
There was a problem hiding this comment.
Do you mind filing an issue for us to think about how we can handle this. It is not ideal for one test to influence every test that comes after it.
This reverts commit 63320aa.
During the review of #7918, it was seen that even if the sender/receiver returns a
status.Internalerror code instead ofstatus.ResourceExhaustedwhen decompression results in a message exceeding the configured max receive message size, no tests fail. This PR adds a test to catch such regressions in the future.RELEASE NOTES: N/A