Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Stats Event Sequencing Documentation and Add Tests for Server-Side Events Sequencing #7883

Closed
wants to merge 1 commit into from

Conversation

RyanBlaney
Copy link

@RyanBlaney RyanBlaney commented Dec 1, 2024

RELEASE NOTES:
Type: Documentation, Test
Improved sequencing documentation for server-side stats events and added tests to verify the event order.

Related Issue

This is in response to Issue #7824

  • Documentation Clarification: Clarified the expected sequencing of stats events in the server-side stats.Handler.
  • New Test Cases: Added tests to verify the event sequencing for various RPC types, ensuring consistency and accuracy in server-side stats handling.

…s to verify the order of server-side events.
Copy link

linux-foundation-easycla bot commented Dec 1, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.21%. Comparing base (4c07bca) to head (94cbd35).

Files with missing lines Patch % Lines
stats/stats.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7883      +/-   ##
==========================================
+ Coverage   81.84%   82.21%   +0.36%     
==========================================
  Files         377      377              
  Lines       38120    38120              
==========================================
+ Hits        31201    31339     +138     
+ Misses       5603     5497     -106     
+ Partials     1316     1284      -32     
Files with missing lines Coverage Δ
stats/stats.go 68.42% <50.00%> (ø)

... and 24 files with indirect coverage changes

@RyanBlaney RyanBlaney closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant