Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/resolver: introduce a new delegating resolver to handle both target URI and proxy address resolution #7857

Merged
merged 75 commits into from
Dec 23, 2024

address comments

fc2c41f
Select commit
Loading
Failed to load commit list.
Merged

internal/resolver: introduce a new delegating resolver to handle both target URI and proxy address resolution #7857

address comments
fc2c41f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 23, 2024 in 0s

82.03% (-0.19%) compared to e5a4eb0

View this Pull Request on Codecov

82.03% (-0.19%) compared to e5a4eb0

Details

Codecov Report

Attention: Patch coverage is 70.28571% with 52 lines in your changes missing coverage. Please review.

Project coverage is 82.03%. Comparing base (e5a4eb0) to head (fc2c41f).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../resolver/delegatingresolver/delegatingresolver.go 68.86% 40 Missing and 12 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7857      +/-   ##
==========================================
- Coverage   82.21%   82.03%   -0.19%     
==========================================
  Files         379      381       +2     
  Lines       38261    38535     +274     
==========================================
+ Hits        31458    31612     +154     
- Misses       5514     5603      +89     
- Partials     1289     1320      +31     
Files with missing lines Coverage Δ
internal/proxyattributes/proxyattributes.go 100.00% <100.00%> (ø)
.../resolver/delegatingresolver/delegatingresolver.go 68.86% <68.86%> (ø)

... and 27 files with indirect coverage changes