Deterministic Subsetting LB policy #6488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Antoine Tollenaere <[email protected]>
This was referenced Jul 31, 2023
|
|
s-matyukevich
commented
Jul 31, 2023
| @@ -82,7 +82,7 @@ not git grep -l 'x/net/context' -- "*.go" | |||
|
|
|||
| # - Do not import math/rand for real library code. Use internal/grpcrand for | |||
| # thread safety. | |||
| git grep -l '"math/rand"' -- "*.go" 2>&1 | not grep -v '^examples\|^stress\|grpcrand\|^benchmark\|wrr_test' | |||
| git grep -l '"math/rand"' -- "*.go" 2>&1 | not grep -v '^examples\|^stress\|grpcrand\|^benchmark\|wrr_test\|deterministicsubsetting' | |||
There was a problem hiding this comment.
We need to use math/rand directly because the algorithm uses round index as seed, so that shuffle results are deterministic.
|
@s-matyukevich : Thank you for this PR and the associated gRFC. One of our TLs is away for a couple of weeks. We will start reviewing the gRFC once they are back. Please expect some delays here. Thanks. |
|
Blocked on the gRFC: grpc/proposal#383 |
|
@s-matyukevich thank you for the PR. I'm going to close this for now, pending the gRFC |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A POC for grpc/proposal#383