Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the UpdateAddresses() method from balancer.SubConn interface #4506

Closed
wants to merge 1 commit into from

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Jun 2, 2021

This is the second and last change as outlined in this issue

Summary of changes:

  • Remove the UpdateAddresses() method from the balancer.SubConn interface
  • Unexport the UpdateAddresses() method on the acBalancerWrapper type.
  • Store the concrete type *acBalancerWrapper in addrConn instead of the balancer.SubConn interface
  • Remove no-op implementations of this method from fake/test subConn implementations used in tests

Fixes #4207

RELEASE NOTES:

@easwars easwars requested a review from dfawley June 2, 2021 23:44
@easwars easwars added this to the 1.39 Release milestone Jun 2, 2021
@easwars easwars added the Type: API Change Breaking API changes (experimental APIs only!) label Jun 2, 2021
@dfawley
Copy link
Member

dfawley commented Jun 4, 2021

Let's discuss this further offline first.

@dfawley dfawley closed this Jun 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: API Change Breaking API changes (experimental APIs only!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upcoming experimental Balancer API changes
2 participants