updating error mdg

test/clientconn_state_transition_test.go

@@ -577,7 +577,7 @@ func (s) TestConnectivityStateSubscriber(t *testing.T) {
 		grpc.WithTransportCredentials(insecure.NewCredentials()),
 	)
 	if err != nil {
-		t.Fatalf("NewClient() failed: %v", err)
+		t.Fatalf("failed to create a client for server: %v", err)
 	}
 	cc.Connect()
 	// Subscribe to state updates.  Use a buffer size of 1 to allow the

test/xds/xds_client_federation_test.go

@@ -244,7 +244,7 @@ func (s) TestClientSideFederationWithOnlyXDSTPStyleLDS(t *testing.T) {
 // is created with a dial target containing an authority which is not specified
 // in the bootstrap configuration. The test verifies that RPCs on the ClientConn
 // fail with an appropriate error.
-func (s) TestFederation_UnknownAuthorityInDialTarget(t *testing.T) {
+func TestFederation_UnknownAuthorityInDialTarget(t *testing.T) {
 	// Setting up the management server is not *really* required for this test
 	// case. All we need is a bootstrap configuration which does not contain the
 	// authority mentioned in the dial target. But setting up the management
@@ -288,10 +288,11 @@ func (s) TestFederation_UnknownAuthorityInDialTarget(t *testing.T) {
 	target = fmt.Sprintf("xds://unknown-authority/%s", serviceName)
 	t.Logf("Dialing target %q with unknown authority which is expected to fail", target)
 	wantErr := fmt.Sprintf("authority \"unknown-authority\" specified in dial target %q is not found in the bootstrap file", target)
-	_, err = grpc.Dial(target, grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithResolvers(xdsResolver))
+	cc, err = grpc.NewClient(target, grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithResolvers(xdsResolver))
 	if err == nil || !strings.Contains(err.Error(), wantErr) {
-		t.Fatalf("grpc.Dial(%q) returned %v, want: %s", target, err, wantErr)
+		t.Fatalf("grpc.NewClient(%q) returned %v, want: %s", target, err, wantErr)
 	}
+	defer cc.Close()
 }
 
 // TestFederation_UnknownAuthorityInReceivedResponse tests the case where the

test/xds/xds_security_config_nack_test.go

@@ -193,7 +193,7 @@ func (s) TestUnmarshalListener_WithUpdateValidatorFunc(t *testing.T) {
 			// Create a ClientConn with the xds scheme and make an RPC.
 			cc, err := grpc.NewClient(fmt.Sprintf("xds:///%s", serviceName), grpc.WithTransportCredentials(creds), grpc.WithResolvers(xdsResolver))
 			if err != nil {
-				t.Fatalf("NewClient() failed: %v", err)
+				t.Fatalf("failed to create a client for server: %v", err)
 			}
 			defer cc.Close()
 

test/xds/xds_server_rbac_test.go

@@ -247,7 +247,7 @@ func (s) TestServerSideXDS_RouteConfiguration(t *testing.T) {
 
 	cc, err := grpc.NewClient(fmt.Sprintf("xds:///%s", serviceName), grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithResolvers(xdsResolver))
 	if err != nil {
-		t.Fatalf("NewClient() failed: %v", err)
+		t.Fatalf("failed to create a client for server: %v", err)
 	}
 	defer cc.Close()
 
@@ -656,7 +656,7 @@ func (s) TestRBACHTTPFilter(t *testing.T) {
 
 				cc, err := grpc.NewClient(fmt.Sprintf("xds:///%s", serviceName), grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithResolvers(xdsResolver))
 				if err != nil {
-					t.Fatalf("NewClient() failed: %v", err)
+					t.Fatalf("failed to create a client for server: %v", err)
 				}
 				defer cc.Close()
 
@@ -838,7 +838,7 @@ func (s) TestRBACToggledOn_WithBadRouteConfiguration(t *testing.T) {
 
 	cc, err := grpc.NewClient(fmt.Sprintf("xds:///%s", serviceName), grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithResolvers(xdsResolver))
 	if err != nil {
-		t.Fatalf("NewClient() failed: %v", err)
+		t.Fatalf("failed to create a client for server: %v", err)
 	}
 	defer cc.Close()
 

xds/internal/balancer/cdsbalancer/cdsbalancer_test.go

@@ -263,7 +263,7 @@ func setupWithManagementServerAndListener(t *testing.T, lis net.Listener) (*e2e.
 
 	cc, err := grpc.NewClient(r.Scheme()+":///test.service", grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithResolvers(r))
 	if err != nil {
-		t.Fatalf("NewClient() failed: %v", err)
+		t.Fatalf("failed to create a client for server: %v", err)
 	}
 	cc.Connect()
 	t.Cleanup(func() { cc.Close() })
@@ -395,7 +395,7 @@ func (s) TestConfigurationUpdate_EmptyCluster(t *testing.T) {
 	// Create a ClientConn with the above manual resolver.
 	cc, err := grpc.NewClient(r.Scheme()+":///test.service", grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithResolvers(r))
 	if err != nil {
-		t.Fatalf("NewClient() failed: %v", err)
+		t.Fatalf("failed to create a client for server: %v", err)
 	}
 	cc.Connect()
 	t.Cleanup(func() { cc.Close() })
@@ -433,7 +433,7 @@ func (s) TestConfigurationUpdate_MissingXdsClient(t *testing.T) {
 	// Create a ClientConn with the above manual resolver.
 	cc, err := grpc.NewClient(r.Scheme()+":///test.service", grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithResolvers(r))
 	if err != nil {
-		t.Fatalf("NewClient() failed: %v", err)
+		t.Fatalf("failed to create a client for server: %v", err)
 	}
 	cc.Connect()
 	t.Cleanup(func() { cc.Close() })

xds/internal/balancer/clusterresolver/e2e_test/balancer_test.go

@@ -100,7 +100,7 @@ func setupAndDial(t *testing.T, bootstrapContents []byte) (*grpc.ClientConn, fun
 	cc, err := grpc.NewClient(r.Scheme()+":///test.service", grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithResolvers(r))
 	if err != nil {
 		xdsClose()
-		t.Fatalf("NewClient() failed: %v", err)
+		t.Fatalf("failed to create a client for server: %v", err)
 	}
 	cc.Connect()
 	return cc, func() {