Move skip to the point of failure

grpc · Jun 26, 2024 · 02fa7a4 · 02fa7a4
1 parent e8cd2bf
commit 02fa7a4
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/xds/internal/balancer/clusterimpl/tests/balancer_test.go b/xds/internal/balancer/clusterimpl/tests/balancer_test.go
@@ -182,8 +182,6 @@ func (s) TestConfigUpdateWithSameLoadReportingServerConfig(t *testing.T) {
 // TestLoadReportingPickFirstMultiLocality tests whether load is reported correctly
 // when using pickfirst with endpoints in multiple localities.
 func (s) TestLoadReportingPickFirstMultiLocality(t *testing.T) {
-	// TODO(#7339): Enable this test once pickfirst has one address per subconn.
-	t.Skip("Skipping due to issue #7339.")
 	originalTickerFactory := transport.TickerFactory
 	tickChan := make(chan time.Time)
 	transport.TickerFactory = func(freq time.Duration) (<-chan time.Time, func()) {
@@ -379,6 +377,8 @@ func (s) TestLoadReportingPickFirstMultiLocality(t *testing.T) {
 	}
 
 	if finalRegion == initialRegion {
+		// TODO(#7339): Enable this test once pickfirst has one address per subconn.
+		t.Skip("Skipping due to issue #7339.")
 		t.Errorf("Unexpected region received traffic: %q", finalRegion)
 	}
 }