Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client xhr transport test #750

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

aran
Copy link
Contributor

@aran aran commented Dec 4, 2024

Depends on #747 .

The added commit is 05eea0d .

This updates client_xhr_transport_test to avoid dart:html, performing some ceremony to work around the unavailability of the previous mock strategy.

Copy link

github-actions bot commented Dec 4, 2024

PR Health

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
grpc Non-Breaking 4.0.1 4.0.2-wip 4.1.0
Got "4.0.2-wip" expected >= "4.1.0" (non-breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
lib/grpc_or_grpcweb.dart 💚 57 %
lib/src/client/transport/xhr_transport.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
grpc Any
$1.Duration

This check can be disabled by tagging the PR with skip-leaking-check.

@aran
Copy link
Contributor Author

aran commented Dec 4, 2024

RFC. There's quite a lot of boilerplate to work around the extension type extern for XMLHttpRequest. More work may be needed here to reimplement some of XMLHttpRequest for the test's expectations, if using this approach.

Help needed: the tests don't pass. I'm not sure how they're supposed to be run, since I run dart test -p chrome I still see errors about the unavailability of dart:js_interop, which is surprising, so something is broken in my mental model.

@aran
Copy link
Contributor Author

aran commented Dec 14, 2024

@Moseum - anyone on maintainer side who could help shepherd this?

@mosuem
Copy link
Contributor

mosuem commented Dec 16, 2024

I think we need to land #747 first, which has some failures at the moment. Happy to see this go through in general, thanks a lot for the initiative!

@aran aran force-pushed the client_xhr_transport_test branch from 05eea0d to c7b9125 Compare December 16, 2024 17:16
@aran
Copy link
Contributor Author

aran commented Dec 16, 2024

@mosuem - should I temporarily remove this test from #747? I see that there is a CI failure in #747 that is related to this test.

@mosuem
Copy link
Contributor

mosuem commented Dec 17, 2024

Help needed: the tests don't pass. I'm not sure how they're supposed to be run, since I run dart test -p chrome I still see errors about the unavailability of dart:js_interop, which is surprising, so something is broken in my mental model.

I see different failures locally - TypeError: null: type 'JSNull' is not a subtype of type 'JSObject'

@mosuem
Copy link
Contributor

mosuem commented Dec 17, 2024

@mosuem - should I temporarily remove this test from #747? I see that there is a CI failure in #747 that is related to this test.

I would suggest to close #747 in favor of this PR, to fix the tests in the same PR as the other changes.

@aran aran force-pushed the client_xhr_transport_test branch from a181372 to 5fee651 Compare December 18, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants