Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding stack trace to more calls of _sendError. #666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

T0bst3r
Copy link

@T0bst3r T0bst3r commented Sep 6, 2023

Hey there dear team

I hope this is the right way to be doing this, if not, or if I missed out on important information, please let me know.

Here I am adding stack trace to more calls of _sendError with the help of records as hinted in #667 (comment).

This should allow for more accurate logging and debugging of issues in custom errorHandlers.

Adding stack trace to more calls of _sendError by using records.

This should allow for more accurate logging and debugging of issues in custom errorHandlers.
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@T0bst3r T0bst3r changed the title Updating handler.dart Allowing ErrorHandler to remove sensitive information Sep 6, 2023
@T0bst3r T0bst3r changed the title Allowing ErrorHandler to remove sensitive information Adding stack trace to more calls of _sendError. Sep 6, 2023
@mosuem
Copy link
Contributor

mosuem commented Sep 15, 2023

Please sign the CLA so this can be reviewed

@T0bst3r
Copy link
Author

T0bst3r commented Sep 15, 2023

I have signed the document at least 4 times by now, it always tells me that it's accepted it and redirects me to my other pull request (#667) but the status here does not change. Emails of both PRs are identical. What can I do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants