-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): Update module golang.org/x/net to v0.33.0 #228
base: master
Are you sure you want to change the base?
Conversation
Can we not do these? It's extremely annoying to keep getting these PRs and none of them has actually ever been an applicable attack vector for this software. |
Yeah, I completely agree. But, most companies have strict compliance requirements on allowing any library with critical/high vulnerabilities. |
It's unclear to me why dependabot isn't sending this PR if it's a high impact vulnerability. :-/ |
I think it could be due to weekly schedule configured here |
I have noticed that @dependabot had problems with this update in other repositories, because when i triggered it manually: ...it failed: In the logs:
It looks like an issue with either @dependabot or the vulnerability data. |
This fix ideally should be done at https://github.com/grpc/grpc-go/blob/master/go.mod. Some offline probe that runs in a container is far less riskier than the actual grpc server in terms of these vulnerabilities. |
@ahmetb Do we want to wait until that gets addressed in grpc-go? |
It is being done in upstream in a rather large PR (because it is a monorepo): Doing the small bump locally here may be quicker. |
Fix for CVE-2024-45338