-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI improvements #948
UI improvements #948
Conversation
app/src/main/java/de/grobox/transportr/trips/detail/TripDrawer.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/grobox/transportr/trips/detail/TripUtils.kt
Outdated
Show resolved
Hide resolved
FWIW, I think this is great. |
Thanks for the feedback :) |
I think I'm going to merge this soon. |
Anything else you're waiting on? |
The only thing I wasn't 100% sure with this PR, is that in some rare cases now to fix #561 we change the color of the line to keep a good contrast. But I think that for now it is better to do it this way and at least have readable lines. In the future we can still think about a better way to handle this :) |
I'll merge it now, but feel free to comment/open an issue if there is anything about this change you wish to discuss :) |
Fixes:
Improves:
Screenshots: